Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix missing swap fields in linux/memory #30774

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Fix missing swap fields in linux/memory #30774

merged 2 commits into from
Mar 10, 2022

Conversation

fearful-symmetry
Copy link
Contributor

@fearful-symmetry fearful-symmetry commented Mar 10, 2022 •
edited
Loading

What does this PR do?

Back when we migrated linux-only metrics from system to linux, it looks like we missed the non-hugepages swap metrics. This adds them back in a way that is backwards compatible with how they were reported in system/memory.

Note: This fix needs to end up in 8.1, but the code also got refactored, so it's probably easier to just create a new PR against 8.1 instead of attempting to backport this.

Why is it important?

These are missing metrics that should have been migrated to linux/memory for 8.0.0.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@fearful-symmetry fearful-symmetry added bug Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Mar 10, 2022
@fearful-symmetry fearful-symmetry requested a review from a team March 10, 2022 18:35
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 10, 2022
@mergify
Copy link
Contributor

mergify bot commented Mar 10, 2022

This pull request does not have a backport label. Could you fix it @fearful-symmetry? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Mar 10, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 10, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-10T18:36:25.498+0000

  • Duration: 86 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 7720
Skipped 2005
Total 9725

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@fearful-symmetry fearful-symmetry merged commit 3695b0b into elastic:main Mar 10, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cmacknz cmacknz cmacknz approved these changes

Assignees

@fearful-symmetry fearful-symmetry

Labels
backport-skip Skip notification from the automated backport with mergify bug Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fearful-symmetry @elasticmachine @cmacknz